Skip to content

Conversation

@aidan-hall
Copy link
Contributor

This makes these symbols visible in backtraces, at the cost of binary size (partially reverts 5e9e68c).

The long-term goal is to generate these functions with LinkOnceODRLinkage, using the contents of the HeapLayout to produce a mangled name, so they can be deduplicated across modules.

rdar://149084103

This makes these symbols visible in backtraces, at the cost of binary size.

The long-term goal is to generate these functions with LinkOnceODRLinkage, using
the contents of the HeapLayout to produce a mangled name, so they can be
deduplicated across modules.

rdar://149084103
@aidan-hall aidan-hall requested a review from drexin December 12, 2025 17:21
@aidan-hall aidan-hall marked this pull request as ready for review December 12, 2025 17:21
@aidan-hall aidan-hall requested a review from rjmccall as a code owner December 12, 2025 17:21
@aidan-hall
Copy link
Contributor Author

@swift-ci smoke test

@slavapestov
Copy link
Contributor

We should do the same for partial apply forwarders too. Today they're generated once per partial_apply call site, but really they only depend on the generic substitutions of the callee so they could be de-duplicated more effectively.

@aidan-hall
Copy link
Contributor Author

@slavapestov

We should do the same for partial apply forwarders too.

Does that mean we should change those to have internal linkage in the short term as well? This PR is just meant as a short-term fix for rdar://149084103. I will be away until after Christmas.

@aidan-hall
Copy link
Contributor Author

@swift-ci test windows

@drexin
Copy link
Contributor

drexin commented Dec 16, 2025

@slavapestov

We should do the same for partial apply forwarders too.

Does that mean we should change those to have internal linkage in the short term as well? This PR is just meant as a short-term fix for rdar://149084103. I will be away until after Christmas.

I think this comment is about the long term plan to deduplicate these functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants